-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sandboxed-process): support for esm files #945
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm sorry, could you please tell me when you're going to merge this? |
Are there plans to pull this in any time soon? As far as I can see it works fine. Not having ESM support for sandboxed workers is a huge PITA. |
This implements the same change as taskforcesh#945
@grahamb I wish it was so easy as to just add support to ESM, the problem is that it breaks other stuff... I wrote this piece of post maybe it is useful to you: https://blog.taskforce.sh/using-typescript-with-bullmq/ |
I saw that post, and no, unfortunately it doesn't help. My workaround for now was to alter the compiled CJS build to use |
Or you can provide a working solution too. |
@manast I've been poking around all the issues and I see when ESM is added it gets reverted due to various reasons. Is there a high level explanation as to what is breaking when |
This is due the way Node works. Depending on the context where you put Bull (i.e. the settings in the package.json of the application depending on Bull) it may break if we enable ESM. It is super hard to make it compatible with all current setups supported by Node. |
@manast What about a separate build? Or should the existing esm build support multiple setups? I am trying to understand what blockers exist in this library or node itself order to support this feature? |
Me too. It is super difficult to get it right, I spent plenty of hours to no avail, besides it is completely ilogical there does not seem to exist any proper way to do it. |
No description provided.